search

emoon / rust_minifb

Cross platfrom window and framebuffer crate for Rust
MIT License
1k stars 95 forks source link

Fix #200 #261

Closed john01dav closed 2 years ago

john01dav commented 2 years ago

200 is important to me so I started working on a fix for it (it appears to not happen in windows, so I just need to make the X11 behavior more consistent with the correct behavior on Windows), but I ran into a road block that I described here. Is there any chance that I could get some help here? Also, I know that the current code on this branch is a mess -- don't worry, I'll clean it up quite a bit once it's working.

emoon commented 2 years ago

Hey,

Thanks for the PR. What exactly do you need help with? I haven't done much in this area so I'm not sure of how much assistance I can be.

john01dav commented 2 years ago

Hey,

Thanks for the PR. What exactly do you need help with? I haven't done much in this area so I'm not sure of how much assistance I can be.

I need help figuring out why XCreateIC is returning null and fixing it. (I can probably fix it myself once I know why it's happening)

emoon commented 2 years ago

I need help figuring out why XCreateIC is returning null and fixing it. (I can probably fix it myself once I know why it's happening)

I have never used this API so I'm not sure what could be wrong here

john01dav commented 2 years ago

@emoon It's all ready to merge now. With regard to the bug I asked for help on, it turned out that I just made a small error in the C FFI for XCreateIC.

emoon commented 2 years ago

Thanks!