emoose / VideoRenderer

RTX HDR modded into MPC-VideoRenderer.
GNU General Public License v3.0
1.28k stars 67 forks source link

Subtitles are extremely bright #29

Open SpacenoidZeon opened 9 months ago

SpacenoidZeon commented 9 months ago

Subtitles are treated as 100% brightness, which can be blinding on HDR displays. White and yellow subtitles in particular display at the screen's full brightness. Subtitle styles can sometimes be manually adjusted as a temporary workaround, but doing this before each time watching a video can be annoying. Some video subtitles are hard-coded and can't be modified, these always display at very high brightness, which again can be very distracting.

As there is already a subtitle brightness slider on this version of the renderer, I would propose that you add a couple more 'lower brightness' settings to the left side of the slider so that the issue can be systemically resolved. That seems like the easiest way to deal with this in the short term. I'd suggest 12.5% increments, from 50% brightness up to 100%, based on the gray levels I end up selecting. I'd use 'setting 1' at 62.5% brightness but I would prefer to solve this for everyone and not just me.

Thank you for your consideration,

Zack

hazelwych commented 9 months ago

Having a similar (possibly related?) issue here, where white subtitles will grey out and desaturate the rest of the screen whenever they appear, regardless of whether or not RTX HDR is enabled and active in NVCP.

ipisano commented 6 months ago

Having the same issue as OP, for me the subtitle/OSD brightness slider doesn't work at all. Can someone confirm if it's working for them or if it's ever worked in older versions? What's more, I can't seem to set custom font colors when using the MPC renderer, but I can see the changes I mad when I switch over to another rendered such as MadVR. Unless you have a very high end panel this kills the HDR experience because every time the subtitles pop up the entire screen changes colors, which is especially noticeable on faces both in real life content and animation. In case someone finds a workaround please feel free to share it.

Edit: I actually found the solution minutes later, I got the renderer from another repo and the slider appears to be working fine https://github.com/qwerttvv/Player/releases