naming

[HellsAngel79]

Is it possible you rename this renderer as im using the aleksoid1978 one for hdr movies but would like to try this out aswell having choice in the player would be better ie madvr this or aleksoid vs constantly register/unregister.

Thanks in advance.

[emoose]

Ah good idea, will look into finding a way to let them both stay registered together, guessing there's probably some GUIDs that might also need changing somewhere...

[clsid2]

As player developer I will tell you that is a terrible idea. Each filter has special handling in most players. You can't just make a "new" renderer an expect it to work properly.

This filter is exactly the same as the original, apart from the extra ability to use VSR. You can simply turn of VSR in NVIDIA settings for doing comparisons. Emoose could also add a new option in the renderer options to toggle the function on/off. There is ZERO reason to have two similar filters installed.

The functionality from this mod will likely also get merged into the original in the future once it has been properly tested.

[HellsAngel79]

As long as hdr works i prefer them seperated like madvr simply select it in the player in my case mpc-hc or aleksoids video renderer and it works settings are per renderer and nothing interfears but im no programmer on what the best way to do this is. bit off topic but madvr used to work fine with hdr now ive given up on it cant get it to switch to hdr luckily aleksoids renderer works fine hence the idea of seperating them and having the selection be done in the player wont have to mess constantly in nvidia control panel either to turn on or off rtx video.

[clsid2]

The added option has no (bad) effect on the HDR functionality. And VSR is not used for HDR.

[HellsAngel79]

The way i understood that if you use hdr theres issues memory leaks crashes hence why i didnt install it due to the same name. also if it does work i dont want hdr movies to be ai upscaled rtx video shouldnt touch that, thats why i like the idea of seperating this renderer from the other let this be its own video renderer targetting a different audience then aleksoid.

[emoose]

Each filter has special handling in most players. You can't just make a "new" renderer an expect it to work properly.

Oh didn't realize that, best left as it is then.

[clsid2]

The memory leak issue was already fixed in v1.1

[HellsAngel79]

hmm well that sucks lol figured the option is there the output in players where renderers show up theres several already. memory leak might be fixed but that still leaves hdr issue.

anyway thanks for atleast giving it some thought :)

[clsid2]

There is no HDR issue. And if you have problems they can be fixed.

[HellsAngel79]

the way i read it at the releases there are "Prevent activating VSR for P010/P016-formatted videos (common in 10-bit H.265) due to memory leak in VSR. A workaround to let those formats be converted & still scaled with VSR can be found at bottom of https://github.com/emoose/VideoRenderer/issues/1#issuecomment-1450964365 (thanks to clsid2 for the tip!)

Prevent activating for HDR content due to HDR being unsupported by VSR."

[HellsAngel79]

accidently send the comment already anyway i didnt install it because of this the names are the same easy fix to me seemed rename the renderer so it shows up in the pulldown menu in output of the player to select it seemed like thats what its there for theres a bunch already evr etc seemed most logic.

[clsid2]

HDR playback works fine and EXACTLY the same as with original renderer!!! What is says is that VSR won't be used in that situation. Which is a limitation of VSR itself.

[HellsAngel79]

ok thats good.