emoose / VideoRenderer

RTX HDR modded into MPC-VideoRenderer.
GNU General Public License v3.0
1.29k stars 67 forks source link

No working #5

Open raffybest94V01 opened 1 year ago

raffybest94V01 commented 1 year ago

I tried to follow the tutorial on how to install and everything, but nothing, it doesn't work, I don't know if it's my windows 10 operating system or the 8700k processor or the 3080 12gb gpu

the only thing that works for me is the mpv player from the anime4k tutorial, the rest doesn't work for me

flflow commented 1 year ago

Same. Looks like not working - no difference with active and not active VSR. изображение изображение

flflow commented 1 year ago

Tested VSR on browser and here is working.

raffybest94V01 commented 1 year ago

but for browser i can simple use the nvidia rtx features, but i want try for the file i download it, like old movie etc... at moment i still use the anime4k reposity, but i wanna see the difference from emoose videorender but i can't because don't work.

emoose commented 1 year ago

Maybe give the build at https://github.com/emoose/VideoRenderer/issues/2#issuecomment-1452134011 a try, also could you try enabling Show statistics and see if it mentions Nvidia-VSR in the overlay?

raffybest94V01 commented 1 year ago

i can't found the statistics, i have try something similar but don't tell me nvidia vsr, open only this little bar bottom Immagine

But now with this build in comment 2 it seems to work, because the consumption in watts has increased from the classic 30w idle up to 70w so it's working.

emoose commented 1 year ago

@raffybest94V01 @flflow could you check if this build is also working for you, and if Nvidia-VSR shows in the "show statistics" stats overlay?

mpc-videorenderer-rtx1.2-3f8c3e2.zip

@raffybest94V01 the "show statistics" is a setting in the MPC-VR properties window (the one flflow posted above at https://github.com/emoose/VideoRenderer/issues/5#issuecomment-1452505734) You can get there in View > Options > Video and click Properties next to MPC Video Renderer

raffybest94V01 commented 1 year ago

Immagine

yes is working ! thanks you emoose <3

just for info, can i combine this video resolution scale, with anime4K filter in some way ?

emoose commented 1 year ago

Looks like there is a DirectShow version of anime4k which might work with it: https://github.com/TianZerL/Anime4KCPP/wiki/Use-in-player

raffybest94V01 commented 1 year ago

tried it, it seems that the anime4k filter overrides your upscale making it in fact useless, i can only choose the nvidia upscaler or the filter, oh well better than nothing thanks for the help

flflow commented 1 year ago

@raffybest94V01 @flflow could you check if this build is also working for you, and if Nvidia-VSR shows in the "show statistics" stats overlay? @emoose Now it looks like working. Perceptible image change. Thank you! изображение

flflow commented 1 year ago

@emoose after restarting player it stops working. изображение

emoose commented 1 year ago

Input format: P010

We prevent scaling for P010 because of memory leak issue, you can follow workaround at https://github.com/emoose/VideoRenderer/issues/1#issuecomment-1450964365 to make it scale again.

flflow commented 1 year ago

@emoose thank you.

ryou128hr commented 1 year ago

It works on mpc be x64 but not on x86. .

rugabunda commented 1 year ago

The first version worked fine, tried 1.1, didn't work, now trying 1.2

rugabunda commented 1 year ago

Confirmed, 1.2 works.....

Pikkuhippi commented 1 year ago

I have same issue as @ryou128hr Is there any way to get it working on x86 version of mpc-hc? It doesnt seem to work for MPC-BE x86 either. I have some other stuff that only work on 32 bit version of the program so would be nice.

The overlay does report that Nvidia-VSR-Requested, but no GPU use is seen or quality improvement. Switching to x64 immediately drives temperature of GPU up. Also tried all the Output Formats. Regardless this is very nice thank you :)

Edit: Managed to get my extra things work in 64-bit MPC anyway, so probably even better I am using 64 bit since allows more memory. Also this looks fricking amazing with motion interpolation.

clsid2 commented 1 year ago

Then problem is on driver side. It is possible that they only activate it in x64 processes.

Hackjjang commented 1 year ago

https://www.microsoftedgeinsider.com/en-us/whats-new

Microsoft Edge Browser VSR - Nvidia RTX 20/30/40 & AMD RX 5700-7800 series support.

emoose commented 1 year ago

@Hackjjang seems to be a new thing separate to NV VSR, neat. Needs edge canary to test it: https://www.microsoftedgeinsider.com/en-us/download/canary Enable it as the page says using the flag, and a HD icon appears in address bar on sites that can use it, which you can click to enable it for that page.

I tried with some 480p videos and didn't really see much difference, the flags page mentions it only upscales to 720p which I guess could be why, maybe it's more noticeable for people with lower screen resolution.

Hackjjang commented 1 year ago

I'm a Radeon user, so I'm even more in need of source reflection on this side.

I'm using an AMD Radeon RX 6700 XT.

Nilssonfpv commented 1 year ago

This isn't exactly a VideoRenderer issue but

Seems VSR is bugged as its not enabling in Chrome or MPC. MPC-HC is showing Nvidia-VSR-requested.

With or without Super Resolution ticked i'm only getting a 30-40W load on my 3080 (msi afterburner) And i'm seeing absolutely no difference in image quality with it on or off on my 3440x1440p monitor.

Tested with various source videos ranging from 480p to 1080p.

Is there any other way of seeing if VSR is active besides actually monitoring gpu power draw? W10 with 431.18 drivers, Chrome 110.0.5481.178

BluestCloud commented 1 year ago

It's now working for me with the 1.3 build. It wasn't working with 1.2.

image

Edit: Spoke too soon. No GPU usage in task manager. VSR works in Edge but not Chrome like other comments.

Pikkuhippi commented 1 year ago

@Nilssonfpv >

Are you using 64-bit MPC? Can you give a screenshot of the Statistics screen like BluestCloud has there (CTRL+J)? And make sure you have 8 bit selected and no dithering on the Renderer settings. If its not enabling for Chrome either maybe try clean install graphics drivers?

Nilssonfpv commented 1 year ago

@Nilssonfpv >

Are you using 64-bit MPC? Can you give a screenshot of the Statistics screen like BluestCloud has there (CTRL+J)? And make sure you have 8 bit selected and no dithering on the Renderer settings. If its not enabling for Chrome either maybe try clean install graphics drivers?

Statistics screen says VSR requested, so it has to be something with the drivers/my windows install.

image

clsid2 commented 1 year ago

You are scaling to an unusual size. See what happens in fullscreen. I would not be surprised if it only works for certain target resolutions.