search

emordonez / connecting-wall

A web implementation of the connecting wall from "Only Connect," built with Vue
https://connecting-wall.netlify.app/
MIT License
15 stars 8 forks source link

Added Support for Hebrew #6

Open bar-boko opened 2 years ago

bar-boko commented 2 years ago

It turns out that you don't support Hebrew in your app, because of the transform to base64 for the link. It doesn't work property with Unicode lauguages.

I found a way to fix it very easily. I'd like to get a permission to create a branch to add this fix.

emordonez commented 2 years ago

Yes, by all means! Thank you for noticing that and bringing it to my attention. Unicode support hadn't occurred to me since the base64 encoding was meant to be a temporary solution until I could find a better way to save walls, but then I forgot about this project, of course :/