search

emorikawa / linkedin-oauth2

Ruby wrapper for the LinkedIn OAuth2 API
Other
70 stars 86 forks source link

Middleware leaky with Faraday #18

Closed epinault closed 9 years ago

epinault commented 9 years ago

I am trying to use twitter and your gem together

But something is off.. Not sure if this is the way this gem work but you create a default middleware that includes @handlers=[Faraday::Request::UrlEncoded, Faraday::Adapter::NetHttp, Twitter::REST::Response::RaiseError]>

Unfortunately something goes awry and now the middleware of twitter are included in your faraday client

so when I try to create a simple client and API call using the linkedin gem, it now fails with

TypeError: no implicit conversion of Symbol into Integer from /home/preseed/.gem/ruby/2.1.3/gems/twitter-5.11.0/lib/twitter/error.rb:75:in `[]'

So are you sure you are suppose to inherit the connection class?

niels commented 9 years ago

This is actually a (namespacing) bug in the https://github.com/sferik/twitter gem.

Fixed in sferik/twitter@a96931171e32c142f36318547f2cffa6ccd5c199. Upgrade your twitter gem to ~> 5.12.0 to resolve this issue.

epinault commented 9 years ago

Thanks! I just upgraded from 5.11 to 5.12 and now it works