search

emory-courses / dsa-java

Data Structures and Algorithms in Java
https://emory.gitbook.io/dsa-java/
42 stars 55 forks source link

[QZ#1 Specifics] #36

Closed TFloyd1989 closed 4 years ago

TFloyd1989 commented 4 years ago

Does it matter if we push our code and it includes code other than the quiz that will cause an error? For example, I started quiz 2 and some of the heap methods may throw an error. Should we delete those error causing files from the repository for the time being, or will you guys just extract the longintegerquiz file code?

marvinquiet commented 4 years ago

Please make sure that if I deleted all other folders except the one for quiz1, the code can run.

Or, please use commit message to indicate your executable version of your Quiz1 code and I can download that version.

TFloyd1989 commented 4 years ago

I can confirm that all files run excluding the queue files

TFloyd1989 commented 4 years ago

For my code, the quiz 1 code is under "quiz 1 update" and not quiz 1 commit

marvinquiet commented 4 years ago

Thanks for letting me know! I will pay attention to it!

TFloyd1989 commented 4 years ago

Just to specify, the following message applies within the cs directories because the different test or main folders themselves have both quiz 1 names(Update & Commit). It is within either the test or main directories where the algebraic folders have been labeled under quiz 1 update

lujiaying commented 4 years ago

Maybe the most convenient way is to submit a "commit ID" (or a URL that refers to your ready version) in your canvas submission. Thus we do not need to refer to this issue. Thanks!

I remembered that I manually figured out some errors introduced by "future" quizzes when grading Quiz#0. But it is somehow time-consuming.

lujiaying commented 4 years ago

@TFloyd1989 Please remember to add the correct commit ID in submission. Otherwise we could not figure which version to use for grading. Thank you.

TFloyd1989 commented 4 years ago

I’m sorry I’m not sure I understand, is there a way to change the commit message after the push?

Get Outlook for iOShttps://aka.ms/o0ukef

From: jiaying.lu notifications@github.com Sent: Saturday, September 12, 2020 10:24:42 PM To: emory-courses/dsa-java dsa-java@noreply.github.com Cc: Floyd II, Terry terry.jamalle.floyd.ii@emory.edu; Mention mention@noreply.github.com Subject: [External] Re: [emory-courses/dsa-java] [QZ#1 Specifics] (#36)

@TFloyd1989https://github.com/TFloyd1989 Please remember to add the correct commit ID in submission. Otherwise we could not figure which version to use for grading. Thank you.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHubhttps://github.com/emory-courses/dsa-java/issues/36#issuecomment-691594960, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AQVOWOHC2KGU3CGX3DZQUR3SFQUOVANCNFSM4RHJBNBQ.

This e-mail message (including any attachments) is for the sole use of the intended recipient(s) and may contain confidential and privileged information. If the reader of this message is not the intended recipient, you are hereby notified that any dissemination, distribution or copying of this message (including any attachments) is strictly prohibited.

If you have received this message in error, please contact the sender by reply e-mail message and destroy all copies of the original message (including attachments).

lujiaying commented 4 years ago

In your repository, there is a list of commits which contains several commits IDs: https://github.com/TFloyd1989/dsa-javaTFII/commits/master .

Please choose the one you think TAs should use to grade, copy it and add it in the Canvas submission/comments. Just let me know if anything is not clear.

TFloyd1989 commented 4 years ago

Would it work better if I just deleted all the other files besides the ones for quiz 1 so that all files can be used?

Get Outlook for iOShttps://aka.ms/o0ukef

From: jiaying.lu notifications@github.com Sent: Saturday, September 12, 2020 10:54:56 PM To: emory-courses/dsa-java dsa-java@noreply.github.com Cc: Floyd II, Terry terry.jamalle.floyd.ii@emory.edu; Mention mention@noreply.github.com Subject: [External] Re: [emory-courses/dsa-java] [QZ#1 Specifics] (#36)

In your repository, there is a list of commits which contains several commits IDs: https://github.com/TFloyd1989/dsa-javaTFII/commits/master .

Please choose the one you think TAs should use to grade, copy it and add it in the Canvas submission. Just let me know if anything is not clear.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHubhttps://github.com/emory-courses/dsa-java/issues/36#issuecomment-691598570, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AQVOWOEYNVJJDEOAVKNZNALSFQYABANCNFSM4RHJBNBQ.

This e-mail message (including any attachments) is for the sole use of the intended recipient(s) and may contain confidential and privileged information. If the reader of this message is not the intended recipient, you are hereby notified that any dissemination, distribution or copying of this message (including any attachments) is strictly prohibited.

If you have received this message in error, please contact the sender by reply e-mail message and destroy all copies of the original message (including attachments).

lujiaying commented 4 years ago

Would it work better if I just deleted all the other files besides the ones for quiz 1 so that all files can be used? Get Outlook for iOShttps://aka.ms/o0ukef … ____ From: jiaying.lu notifications@github.com Sent: Saturday, September 12, 2020 10:54:56 PM To: emory-courses/dsa-java dsa-java@noreply.github.com Cc: Floyd II, Terry terry.jamalle.floyd.ii@emory.edu; Mention mention@noreply.github.com Subject: [External] Re: [emory-courses/dsa-java] [QZ#1 Specifics] (#36) In your repository, there is a list of commits which contains several commits IDs: https://github.com/TFloyd1989/dsa-javaTFII/commits/master . Please choose the one you think TAs should use to grade, copy it and add it in the Canvas submission. Just let me know if anything is not clear. — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub<#36 (comment)>, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AQVOWOEYNVJJDEOAVKNZNALSFQYABANCNFSM4RHJBNBQ. ____ This e-mail message (including any attachments) is for the sole use of the intended recipient(s) and may contain confidential and privileged information. If the reader of this message is not the intended recipient, you are hereby notified that any dissemination, distribution or copying of this message (including any attachments) is strictly prohibited. If you have received this message in error, please contact the sender by reply e-mail message and destroy all copies of the original message (including attachments).

That works too. Please feel free to do either way you prefer.

Containing not-compilable files in repo would lead grading process complicated.

TFloyd1989 commented 4 years ago

I can confirm I have deleted all queue related files, so the only code present is from Quiz 1 and Quiz 2. Should I resubmit the assignment as well?

marvinquiet commented 4 years ago

Just make sure your Quiz1 code can pass all the tests. I will grade according to Quiz1 only