emory-libraries / OpenEmory

open-access repository for scholarly articles, based on Fedora Commons
open.library.emory.edu
2 stars 2 forks source link

Adjust/remove header elements #190

Closed eporter23 closed 1 year ago

eporter23 commented 1 year ago

Because the OpenEmory site was originally launched in 2013, there are 2 header elements that are out of date and need revision or removal.

Screen Shot 2023-07-20 at 9.41.49 AM.png

eporter23 commented 1 year ago

Due to competing projects, we are moving this into the Backlog for now.

eporter23 commented 1 year ago

@bwatson78 , @rotated8 and I discussed this as work we'd like to complete before the project closes on 8/31. We're hoping you may be able to tackle this to get it off Zo's plate. We'll discuss more during sprint planning.

bwatson78 commented 1 year ago

PR made: https://github.com/emory-libraries/OpenEmory/pull/212

eporter23 commented 1 year ago

We will deploy to testopen first, then production

eporter23 commented 1 year ago

@bwatson78 looks good, but I am still seeing the Schools | Libraries | Resources menu in testopen.library: Private Zenhub Image

bwatson78 commented 1 year ago

I just checked both testopen and prod, and I see that that menu is gone in testopen, and that none of the intended changes are live on prod yet.

bwatson78 commented 1 year ago

Safari? No, I don't see those elements there either.

bwatson78 commented 1 year ago

@eporter23 Is it present on all of your page views, or just certain endpoints?

eporter23 commented 1 year ago

@bwatson78 just cleared cache etc in Chrome and I see the change now. Unfortunately the lower menu position has shifted upwards, are you seeing this too? (the Browse/About/etc menus should be flush with the bottom of the darker blue header element.) I'll look at it in more detail but I guess my visibility quick fix isn't quite enough.

Screen Shot 2023-08-16 at 12 50 28 PM
bwatson78 commented 1 year ago

I'll work on that!

eporter23 commented 1 year ago

Looks great, thanks for the additional work on this.