search

emory-libraries / Pattern-Library

Minimal pattern library based on Emory Libraries' website redesign
0 stars 1 forks source link

Create new pattern Template::Form #181

Closed kristianserrano closed 5 years ago

kristianserrano commented 5 years ago

Testing

qa /services/visitor-library-materials-request

laurenhamel commented 5 years ago

@kristianserrano, since this is a template pattern, I think this needs to be moved back to "In Progress," and additional work should be done to also include setup within the templating engine. That should mostly entail pushing the template into the templating engine, assigning its associated Cascade page type, and setting up the CMS data to pattern data model mutations for the template.

laurenhamel commented 5 years ago

@kristianserrano, I wanted to double check to see if you got my comment above. Since we just merged some changes into the templating engine, I think now would be a good time to work on building the mutations for this template in the templating engine. I imagine that it won't be too time consuming given the page type. If you can get this done by EOD, I'm going to try reviewing and closing out the remaining PRs you submitted.

laurenhamel commented 5 years ago

Moving this back to "In Progress" to help declutter everything that needs to be tested.

kristianserrano commented 5 years ago

@laurenhamel I'm going to finish this up.

kristianserrano commented 5 years ago

@laurenhamel This has been updated with dev and pushed on all three repos.

laurenhamel commented 5 years ago

@nikdragovic, this has been deployed to qa. I'm not sure if there are any page types using this pattern currently, so I left the testing links above TBD for the time being.

nikdragovic commented 5 years ago

@laurenhamel I am accepting based on what I see here:

http://qa.libraries.emory.edu/services/visitor-library-materials-request

One note - I think we may want to see if we can get the styles of the form to match the site, but that would be on the SpringShare / LibWizard side.

kristianserrano commented 5 years ago

@nikdragovic agreed. We'll want to update the in LibWizard like we had once before (which now seem to be missing), but it should be noted that those styles will appear on all of the other sites that use LibWizard forms.

nikdragovic commented 5 years ago

@laurenhamel Sorry, it looks like I actually wasn't able to publish the dummy intro text here, so let's look at that: https://cascade.emory.edu/entity/open.act?id=01b223510ae720984942c44cdabb5a46&type=page&confId=28b32c840ae720982da9b0c813ad929a

nikdragovic commented 5 years ago

@kristianserrano Sorry, what is missing? The styles in LibWizard, or some sort of link?

kristianserrano commented 5 years ago

@nikdragovic The styles that used to be in LibWizard that were based on our current site.

laurenhamel commented 5 years ago

@nikdragovic, has this been resolved? I was going to deploy everything from Sprint 12 to staging, but I see that this is still not formerly accepted. As @kristianserrano was mentioning, the CSS styles differ in the LibWizard forms due to embeds. To help get this issue accepted, I think it's probably best that we create a new issue to capture the work needed around having those styles updated.

nikdragovic commented 5 years ago

@laurenhamel Yes, let's create a new issue for the LibWizard work. The reason this is not yet accepted is that I am still not seeing the intro text in Cascade display:

http://qa.libraries.emory.edu/services/visitor-library-materials-request

kristianserrano commented 5 years ago

@nikdragovic and @laurenhamel I began work on this last night. Should be wrapped up at some point today. @laurenhamel looking at the related main and intro hbs files, I'm not quite sure why it's not populating already. Might need to walk through it with you to track it down.

kristianserrano commented 5 years ago

@laurenhamel and @nikdragovic I've modified the styles for form pages to display the introduction. This is ready to test (again).

nikdragovic commented 5 years ago

@kristianserrano I still can't get this intro text to display:

https://cascade.emory.edu/entity/open.act?id=01b223510ae720984942c44cdabb5a46&type=page&confId=28b32c840ae720982da9b0c813ad929a

kristianserrano commented 5 years ago

It's not deployed to QA yet. I was formally waiting for PR review. Just wanted to let you know it was worked on and solved. @laurenhamel I can merge and deploy to QA if that's ok with you.

nikdragovic commented 5 years ago

@kristianserrano Apologies, didn't realize it was in this column.

laurenhamel commented 5 years ago

@nikdragovic, this has been moved into qa and is ready for testing. The fixes for the services directory page was also included.

nikdragovic commented 5 years ago

I am still unable to get the intro text to display here:

http://qa.libraries.emory.edu/services/visitor-library-materials-request

nikdragovic commented 5 years ago

The label is displaying correctly on the Services Directory after reindexing, though:

http://qa.libraries.emory.edu/services/index

laurenhamel commented 5 years ago

@nikdragovic, is your page cached? I just tried the link again, and I'm seeing the subtitle text.

nikdragovic commented 5 years ago

Thanks @laurenhamel. It worked; I forgot to try that. Accepting now.