search

emory-libraries / Pattern-Library

Minimal pattern library based on Emory Libraries' website redesign
0 stars 1 forks source link

Validate supplied URL against set list #391

Closed elliotkendall closed 4 years ago

elliotkendall commented 4 years ago

This patch changes proxy.php to only work on a specific list of URLs. Per web server logs, these are the only URLs that the script should be used with.

elliotkendall commented 4 years ago

Why do these feeds need to be proxied through the web server in the first place? Why can't they simply be loaded by the client browser?

rosy1280 commented 4 years ago

The data is being pulled and reformatted because the various feeds do not conform to the same standards, but are all being outputted to the same location on the webpage.

Requesting a change larger than the simple change proposed to proxy.php will take developer resources that we clearly lack in the libraries because of attrition and the hiring freeze. Lets stick to the issue with proxy.php for now.

elliotkendall commented 4 years ago

But proxy.php doesn't do any kind of reformatting. It literally just requests the passed URL and outputs the result.

If development is ongoing to add new feeds, can't that include getting them to work properly without this proxy hack?

rosy1280 commented 4 years ago

@elliotkendall as requested, please stick to the needs of proxy.php only. we are identifying a short term fix here. not a long term one.

rosy1280 commented 4 years ago

in #388 we've limited the request to the trumba, scholarblogs, and rssmixins domain. so we'll close this PR in favor of that one.