emory-libraries / aspace

0 stars 0 forks source link

Adjust font and color styling for ASpace PUI #102

Closed erussey closed 1 year ago

erussey commented 1 year ago

A couple of adjustments need to be made to headers.

maxdmayhew commented 1 year ago

Screenshot 2023-03-08 at 9.49.31 PM.png

Screenshot 2023-03-08 at 9.51.52 PM.png

Screenshot 2023-03-08 at 9.52.06 PM.png

Here are the three different pages mentioned. The last one (aspace saerch) for some reason is displayed as an h2 instead of an h3 like the other two. I can change it but I will need to override the existing template.

Screenshot 2023-03-08 at 9.51.58 PM.png

Above is a decent reason to keep the font larger on the search page (3rd image) since it the only thing really on the page.

image.png

maxdmayhew commented 1 year ago

Will submit PR after approval or additional changes are made.

erussey commented 1 year ago

@maxdmayhew : this looks ok to me. I don't want to override existing templates. We'll catch some of this in the accessibility review that we'll do towards the end of the project. If we find accessibility issues/inconsistencies in the core code, I can put in a series of tickets to have them fixed by the ASpace community devs.

maxdmayhew commented 1 year ago

The one issue I've noticed is appropriate use and nesting of headings. It might be best to just focus on our platform for now since we have a fairly customized implementation of this system.

https://accessibility.princeton.edu/how/content/headings