emory-libraries / aspace

0 stars 0 forks source link

Add a new button to archival object pages to provide users with additional information about requesting #140

Closed erussey closed 1 year ago

erussey commented 1 year ago

Create a button that points to a help page to help patrons with requesting. This button should open a new tab, which is what is the default behavior of the other buttons. These buttons appear on archival object and resource object display pages.

Examples:

https://archives-test.libraries.emory.edu/repositories/7/resources/4339 Screenshot 2023-04-28 at 9.12.23 AM.png

https://archives-test.libraries.emory.edu/repositories/7/archival_objects/499592 Screenshot 2023-04-28 at 9.13.44 AM.png

https://archives-test.libraries.emory.edu/repositories/7/archival_objects/504726 Screenshot 2023-04-28 at 9.15.37 AM.png

maxdmayhew commented 1 year ago

Since the "help requesting" page will still be within the archives website, best practice is to keep from opening a new tab. Here is what I have so far.

Screenshot 2023-04-28 at 6.53.53 PM.png

The layout might need to be tweaked (because of the "No Access" & "No requestable containers" messages) but we can reassess on the next deploy.

bwatson78 commented 1 year ago

Backend's responsibility has been fulfilled by https://github.com/emory-libraries/aspace_static_plugins/pull/46, which has been approved and merged into main.

maxdmayhew commented 1 year ago

Screenshot 2023-05-01 at 12.53.30 PM.png

button now links to help-requesting page with placeholder text.

submitting PR

erussey commented 1 year ago

@maxdmayhew : A couple of text changes:

Page link is still fine, I think.

erussey commented 1 year ago

@maxdmayhew : What is the update on this story? It looks like the final task is not done yet? I realize that the help page does not have text yet, which the archivists are still working on. Could we release the button/dummy page to test once the last task is done and put a story in the next sprint to add the text?

Please make sure that the help page opens in a new tab. I know that isn't best practice, but it is what we are doing for the header and will ensure that patrons visiting the help page do not have to redo their search.

maxdmayhew commented 1 year ago

PR Submitted. I made the link open in a new tab but links in the header open in new tabs because they link to external sites.

We want to keep things consistent from a UX perspective and this behavior can be disorienting for users.

erussey commented 1 year ago

The button structure here is not ideal. @maxdmayhew : I'm not sure if anything can be done about this, but the buttons get jumbled with longer titles:

Screenshot 2023-05-10 at 10.15.28 AM.png

maxdmayhew commented 1 year ago

So this is because of the "No requestable containers" alert, not the title. However, it's still an issue.

Screenshot 2023-05-10 at 11.13.50 AM.png

I think I can get the "no requestable containers" alert to show up last like I have here. And push everything to the right side. What do you think of this @erussey?

maxdmayhew commented 1 year ago

submitting PR, this is sort of a test since the "no requestable containers" alert doesn't show up on my local instance.

maxdmayhew commented 1 year ago

https://github.com/emory-libraries/aspace_static_plugins/pull/49