emory-libraries / aspace

0 stars 0 forks source link

Rework header structure on Emory adjusted pages #141

Closed erussey closed 1 year ago

erussey commented 1 year ago

Fix header structure on homepage and help pages to address missing <h2> element to optimize screen reader responsiveness.

Affected pages are: https://archives-test.libraries.emory.edu/help https://archives-test.libraries.emory.edu/help-requesting https://archives-test.libraries.emory.edu/ https://archives-test.libraries.emory.edu/about

CB987 commented 1 year ago

Screenshot 2023-05-16 at 11.54.05 AM.png

Screenshot 2023-05-15 at 8.01.50 PM.png

CB987 commented 1 year ago

@erussey before i PR i wanted to get your feedback. i can demo on my local if the screenshots are not clear/helpful.

erussey commented 1 year ago

@CB987 : the above is ok (and a simple solution, so thank you).

erussey commented 1 year ago

@CB987 : I don't know how to test this?

CB987 commented 1 year ago

Screenshot from current test site with corrected headings hierarchy, this is not noted as an issue. Screenshot 2023-05-23 at 5.00.26 PM.png On production you can see the issue still exists. Screenshot 2023-05-23 at 4.58.07 PM.png

erussey commented 1 year ago

Great, thanks @CB987 !

CB987 commented 1 year ago

and on the home page: prod, with issue noted: Screenshot 2023-05-23 at 5.07.08 PM.png test, no longer reports that issue: [Uploading... Screenshot 2023-05-23 at 5.07.45 PM.png]