emory-libraries / aspace

0 stars 0 forks source link

Configure admin/staff header #75

Closed erussey closed 1 year ago

erussey commented 1 year ago

-Maintain the default menus and buttons on the right.

CB987 commented 1 year ago

Started on this but nothing to see, mostly setting up files and haven't pushed anything yet.

erussey commented 1 year ago

Please @CB987 check the spacing of how the page displays...for some reason everything is tabbed in a bit?Screen Shot 2023-02-15 at 2.01.42 PM.png

CB987 commented 1 year ago

that's weird, but also they shouldn't have anything from me yet.

CB987 commented 1 year ago

Screen Shot 2023-02-20 at 7.41.51 PM.png So far. Need to fix background of other dropdown menus (assume we want them all dark letter on white background?) branding font size. anything else?

CB987 commented 1 year ago

Changes requested by Elizabeth yesterday are in progress.

CB987 commented 1 year ago

Screen Shot 2023-02-22 at 4.07.17 PM.png @erussey this is configured ;) with minimal changes to actual code. does this have more the look that you were thinking?

CB987 commented 1 year ago

(for future reference, changes made using these instructions: https://archivesspace.github.io/tech-docs/customization/theming.html)

erussey commented 1 year ago

@CB987 : in the latest deploy, something happened. It's not looking like the screenshot above.

CB987 commented 1 year ago

Hmm, i see that the image link is broken. I will look into that, thanks!

CB987 commented 1 year ago

I traced the issue with the image. The instructions are a little contradictory, and since it was working on my local I didn't dig any deeper. It needs redeploying, but the fix should be in place now (do I need to reach out to Blake again for redeploy, or is it ok until next monday?) On the page linked above, it says to follow a code example using image_tag, but then in a note it says that rails tag helpers like image_tag won't work "will not be precompiled by the Rails asset pipeline". So it just had to be refactored to use html, not erb. This is good to note for future errors.

erussey commented 1 year ago

Just adding the note that the login info is tabbed over to the left instead of flush, which needs to be fixed as well.

CB987 commented 1 year ago

Increased estimate to 5 because additional work was needed after deploy revealed that there were unforeseen interactions with other plugins only available on the test site, not locally. I had a meeting with Blake from Lyrasis and have a new PR which hopefully will address those issues, but we will not know until they are deployed.

rotated8 commented 1 year ago

Blocked, @CB987 will reach out to Blake to ensure current approach will work.

erussey commented 1 year ago

I am assuming that the blue is there. I can't see it because it's overridden by #78.