emory-libraries / aspace

0 stars 0 forks source link

Implement label plug-in #80

Closed erussey closed 1 year ago

erussey commented 1 year ago

Customize and configure the Dartmouth label plug-in: https://github.com/dartmouth-dltg/container_management_labels

Labels should display the following fields (centered on label): See example in comments Institution Name (small) Repository Name (small)

space

Resource identifier (bold)

space

Resource Creator name and date (this is an Agent with role=creator) Resource title

space

Container type and indicator

Label brands and sizes (staff users should be able to pick the label they want to use): Avery 3 1/3" x 4" (6 labels/sheet) Avery 2" x 4" (10 labels/sheet) **Margins will have to be smaller and spaces will have to be smaller for the 3 1/3" x 4"

See related ticket #25

erussey commented 1 year ago

Screen Shot 2023-01-27 at 11.11.59 AM.png

erussey commented 1 year ago

I'm not entirely sure how the document for printing is created, but I can send along a document with margins that we'll need for each label type above.

bwatson78 commented 1 year ago

The reason for this estimate increase is because a simple implementation isn't producing the expected labels, but a chain of errors that seem to be related to some Rails/Ruby upgrade.

bwatson78 commented 1 year ago

The plugin has been forked into our Github and customized, located here: https://github.com/emory-libraries/container_management_labels

The PR to initialize/incorporate the plugin: https://github.com/emory-libraries/aspace-deployment/pull/4

It appears that all of the values listed above must be populated in order for the labels to build and deliver. The litany of errors I received were based upon missing values in containers that were provided by the the ArchiveSpace application. When I chose a Container that had a Collection associated with it and all variables present, it formed correctly.

If we expect to create labels for Containers that do not have all of these values populated, we may want to create further issues to protect against empty data and associations.

bwatson78 commented 1 year ago

https://app.zenhub.com/files/531984195/cab988c4-7fd8-4061-a958-5be246eaad70/download https://app.zenhub.com/files/531984195/d1328525-d138-4f03-b2c2-e02bd0466715/download Screen Shot 2023-02-13 at 9.42.50 AM.png

bwatson78 commented 1 year ago

PR merged, just awaiting a deploy to the live environments.

erussey commented 1 year ago

@bwatson78 : Obviously, this will have to be tested in the live environment before we can call it done. But can we adjust what ends up in the label printouts? The screenshots you provided above do not match the requirements in the original ticket...we'd like to match our current labels as much as possible. So, for instance, I'd like all the text to be the same and not greyed out, no lines, no italics, etc. Ideally, we'd test this plug-in on our own live data first and then adjust. Based on the screenshots above of the plug-in in the UI, I think we have all the right data. It just needs to be displayed on the label differently.

maxdmayhew commented 1 year ago

Screen Shot 2023-02-24 at 11.08.21 AM.png

Screen Shot 2023-02-24 at 11.07.48 AM.png

There are a few issues with this that I am seeing already.

maxdmayhew commented 1 year ago

image.png

page breaks seem to be working now. I am thinking that setting the margins manually when printing is going to be our best approach.

erussey commented 1 year ago

@maxdmayhew : This may not have been deployed yet? I'm still seeing old styling in the plug-in output.Screen Shot 2023-02-28 at 6.27.59 PM.png

maxdmayhew commented 1 year ago

I apologize, I apparently never put in a PR for this. I just submitted one and I can see if we can get this deployed sooner than next week?

https://github.com/emory-libraries/container_management_labels/pull/3

erussey commented 1 year ago

Here's what I tested:

I tried the above both with setting custom margins and using the default. Both had the same result.

erussey commented 1 year ago

As discussed in standup on 3/10, we will do a check in on this ticket at sprint end to see how close we are to resolving issues. If not complete, we'll put in blocked and revisit in April/May when dev work picks up again.

maxdmayhew commented 1 year ago

Need to change the estimate due to the amount of time this is ultimately taking. The changes/updates are fairly straightforward but the issues (like the page drift) that seem to be happening on the printer are a bit odd and will need a bit more time to resolve.

erussey commented 1 year ago

@maxdmayhew : The bigger labels you're trying to find a template for are Avery 5164. The 22513 may be an older version of the same label, but confirmed today that they are using 5164. So we have two label sizes: 5164 (the bigger ones) and 5163 (the smaller 2x4 ones).

maxdmayhew commented 1 year ago

Made various edits to way the layout is handled, PR was just merged a few minutes ago.

@erussey you can test this after todays deploy. Both 22513 (5164) and 5163 are ready to test.

erussey commented 1 year ago

This looks awesome @maxdmayhew ! Thanks so much!