search

emory-libraries / blacklight-catalog

1 stars 2 forks source link

Allow "X" as a valid character for ISSN, ISBN optimized search filters #1264

Closed eporter23 closed 2 years ago

eporter23 commented 2 years ago

This ticket follows work done in #1226 to enhance ISBN and ISSN searches. After deployment to production, the ILL team has reported a few anomalies related to ISSN searches specifically, but this could also apply to ISBNs:

0048671X vs. 0048-671X In this case, I suspect the inclusion of "X" may be breaking the pattern we expected. The ISSN specification does allow X in addition to numbers and hyphens.

NOTE: "X" is a valid character in the ISBN specification also.

Fields to modify for the SOLR search filters:

issn_t

isbn_t

bwatson78 commented 2 years ago

PR made: https://github.com/emory-libraries/blacklight-catalog/pull/1265

eporter23 commented 2 years ago

@bwatson78 @lovinscari looks great! This is ready to go to prod whenever that is next scheduled.