Closed tmiles2 closed 2 years ago
@devanshu-m I tried testing against a few known collections and they don't seem to be coming up in the results (example: Raymond Danowski or Ted Hughes). Is this lookup pointed to the collection_ssim
field?
@eporter23 do we have collection names that are more than 255 characters? Names are saved in a database table as strings. If we have names more than 255 characters, I am guessing the save threw an error and stopped processing rest of the collection names.
@devanshu-m looks like we do have some long titles there. Here's an example of one with more than 255 chars: https://blackcat-test.library.emory.edu/catalog/990031862080302486
1976: Mental health statistical note / U.S. Department of Health, Education and Welfare, Public Health Service, Alcohol, Drug Abuse and Mental Health Administration, National Institute of Mental Health, Division of Biometry and Epidemiology, Survey and Reports Branch ; no. 144
@eporter23 ok I can change columns to text and see if that helps.
@eporter23 I have reviewed the overall functionality but I would like you to confirm the work done to correct the formatting of the long titles meets your expectations. Please close once you have reviewed assuming all is working as expected.
Discussed with @devanshu-m and @bwatson78 making some further changes to optimize page load time. Suggestions include switching the lookup to use emory_collection_tesim (Emory-named collections only) and only loading the first 100 or so titles in the drop box until a user starts typing.
@eporter will create a new ticket for work on optimization of page load times.
This ticket follows prior work to enhance the page load time on the Advanced Search form, which was previously very slow when the Collections facet/filter was enabled.
In spike #510, several options were proposed to resolve this issue by changing how the collection facet is loaded and searched. Notes are copied below:
There have been multiple suggestions on how to handle facets with large numbers of values. The suggestions can be categorized two ways: 1. live searching of the problem fields via Solr, producing results limited to a number chosen by stakeholders, and 2. ajax querying a cache of all values that are updated whenever a reindex occurs. These suggestions can be applied to all facet fields, or just a selection, but bear in mind, when we carve out just a couple of the fields to work differently than the others, it increases the amount of code to write (more time spent) and may lead to user confusion.
Live Searching Solr Pros:
Cached Searching Here, the Cons reside in the forms of caching available to us. I will break each one of those out below. Pros:
Caching Methods