emory-libraries / dlp-lux

Discovery for the DLP Cor Repository
2 stars 0 forks source link

Stack traces in Curate still visible #551

Closed maxkadel closed 4 years ago

maxkadel commented 4 years ago

Unauthenticated users can see stack traces on Curate via the iiif controller, which can be a security issue, as well as being unpolished.

image.png

In addition, when Fedora can't find an object, it creates an error:

https://curate-arch.library.emory.edu/iiif/2/1e9ad3613b229dd3d4c786c5a22ed69a6efac786/info.json

image.png

rotated8 commented 4 years ago

Merged, pending deploy

maxkadel commented 4 years ago

No longer getting a stack trace, getting routed to the expected URL, then getting appropriate 404 status and error message image.png

Errors are being logged to Honeybadger and grouped appropriately (if these show up again, or in production, you'll want to chase down the missing files) image.png

https://app.honeybadger.io/projects/66999/faults/63289982