emory-libraries / dlp-lux

Discovery for the DLP Cor Repository
2 stars 0 forks source link

Don't hard-code date #554

Closed maxkadel closed 4 years ago

maxkadel commented 4 years ago

https://github.com/emory-libraries/dlp-lux/blob/b2015700bbf326f1a232ea8958502ef918066c97/app/views/blacklight_range_limit/_range_limit_panel.html.erb#L82

Acceptance Criteria

bwatson78 commented 4 years ago

Just a heads-up: This is almost impossible to test (writing an expectation that this will always display the current year as the end year range). When I researched this gem to try to get it working for Curate, I found that the code is written to always prefer Solr Stats' min/max for each data field rather than use either assumed_boundaries (set in the catalog_controller) or the values set in the range_limit_panel_url call in the range_limit_panel partial override.

rotated8 commented 4 years ago

You can use Date.today.year to test

bwatson78 commented 4 years ago

After speaking with Collin, he decided that I should remove the setting of those arguments since they don't factor into how the gem processes the range.

bwatson78 commented 4 years ago

PR made: https://github.com/emory-libraries/dlp-lux/pull/644

bwatson78 commented 4 years ago

No screenshot needed since this doesn't affect any UI.