search

emory-libraries / dlp-lux

Discovery for the DLP Cor Repository
2 stars 0 forks source link

Prevents erroneous dates like "0ad" by only adding "issued" variable… #612

Closed bwatson78 closed 4 years ago

bwatson78 commented 4 years ago

…to citeproc gem when date is available.

Also bolsters citation processor testing and refactors based on additional testing.

  1. citation_formatter.rb: adds new method that inserts "issued" when right fields are present.
  2. citation_string_processor.rb: refactors methods for error proofing and reusability.
  3. citation_formatter_spec.rb: swaps out calls to new ones with arguments.
  4. citation_string_processor_spec.rb: creates new spec to test methods that did not already have them.
bwatson78 commented 4 years ago
Screen Shot 2020-05-21 at 10 53 31 AM
bwatson78 commented 4 years ago

@wulman16 Change requests have been addressed.