Add definition list to search result page component

emory-libraries / dlp-lux

Discovery for the DLP Cor Repository

2 stars 0 forks source link

Add definition list to search result page component #655

Closed nikdragovic closed 3 years ago

nikdragovic commented 3 years ago

The second-row element is in app/views/catalog/_index_header.html.erb

Acceptance Criteria

[x] Wrap list currently in document-heading-second-row in a definition list (dl)element so that screen readers can properly announce them.
[x] If this is modifying default Blacklight behavior, report it back to the community.

nikdragovic commented 3 years ago

@bwatson78 This appears to be what is flagged, from what I can tell. I'm not sure how this would be defined if so; it's just empty space. Screen Shot 2020-07-22 at 10.40.44 AM.png

bwatson78 commented 3 years ago

@nikdragovic and @eporter23: This isn't blacklight standard behavior, rather our custom iterations.

bwatson78 commented 3 years ago

PR made: https://github.com/emory-libraries/dlp-lux/pull/663

Screen Shot 2020-07-23 at 8.08.22 AM.png