Definition lists for show page components

nikdragovic commented 3 years ago

Acceptance Criteria

[ ] For “this item is part of / this item contains / view items in this digital collection" section, ensure that the definition list is constructed correctly so that screen readers don’t give confusing output.
[ ] For Access and Copyright sections, ensure that the definition list is constructed correctly so that screen readers don’t give confusing output.

bwatson78 commented 3 years ago

@nikdragovic Recommendations:

All card divs that have classes that contain the card title hyphenated ("This Item Is Part Of" -> class="is-part-of") should also have a title attribute that repeats the same card title.
Each dl directly inside the div with the class "card-body" should have a descriptive title.
The "Tools" card lacks the class "card-body", probably because of styling reasons. I'd recommend the title attribute go on the div with the classes "card mb-2 rounded-0". When I researched the accessibility of uls/lis, I found that there shouldn't be any issue, unless it's a list of menu options (I think this counts as a menu.) We may consider adding a title to the ul and each li to fully describe what their options are here.

bwatson78 commented 3 years ago

Screen Shot 2020-07-24 at 7.29.16 AM.png Screen Shot 2020-07-24 at 7.28.34 AM.png

bwatson78 commented 3 years ago