emory-libraries / dlp-lux

Discovery for the DLP Cor Repository
2 stars 0 forks source link

Add alt text to collection hero images #659

Closed nikdragovic closed 4 years ago

nikdragovic commented 4 years ago

Acceptance Criteria

Screen Shot 2020-07-22 at 9.46.56 AM.png

bwatson78 commented 4 years ago

PR made: https://github.com/emory-libraries/dlp-lux/pull/670

bwatson78 commented 4 years ago

Screen Shot 2020-07-27 at 11.49.08 AM.png

nikdragovic commented 4 years ago

@bwatson78 I don't seem to be able to load collection heros in test:

https://digital-test.library.emory.edu/catalog/914nk98sfv-cor

https://digital-test.library.emory.edu/catalog/5053ffbg7n-cor

https://digital-test.library.emory.edu/catalog/914nk98sfv-cor

bwatson78 commented 4 years ago

@nikdragovic Looking into this.

bwatson78 commented 4 years ago

@nikdragovic First finding is that the banner_path_ss solr field is wrong. My code didn't touch any manipulation of solr fields, so I'm digging deeper.

nikdragovic commented 4 years ago

@bwatson78 Quick add - collection objects in arch have working heros, except for Langmuir.

https://digital-arch.library.emory.edu/catalog/699n2z34v3-cor

https://digital-arch.library.emory.edu/catalog/105s7h44j3-cor

bwatson78 commented 4 years ago

@nikdragovic Lux doesn't manipulate anything related to the banner_path_ss field when it comes in from Curate. I'm now looking at the Curate code.

bwatson78 commented 4 years ago

@nikdragovic I believe there may have been a transferring of objects from test to arch recently. For example, the path to the collection banner image in Arch for Langmuir is "/mnt/test_efs/uploads/dlp-curate/branding/699n2z34v3-cor/banner/40644j0ztx-cor.jpg". The code that properly formats the path is expecting to scrub "/mnt/arch_efs/uploads/dlp-curate". I think the location of the banner was imported directly from test without manipulation. I think this is a problem we've had in the past, but I'm not sure the fix. Reindexing?