emory-libraries / dlp-selfdeposit

0 stars 0 forks source link

Unwanted blank second entries on certain fields when editing in the form: spike ticket #576

Closed eporter23 closed 1 week ago

eporter23 commented 1 month ago

This may be a default Hyrax behavior or bug, but in order to have a more user friendly form for depositors, we should investigate if the following can be addressed. This also relates to the issue described in #569.

When a user edits an existing work, a blank entry with a "remove" button appears even if they have not entered anything or clicked the Add Another link beneath it. This behavior applies to certain fields that Hyrax defaults to being multivalued, but we locally define as single valued.

Title Publisher Copyright Statement

This behavior also applies to all other non-required, multivalued fields such as: Final Published Version Grant/Funding Information

eporter23 commented 1 month ago

Discussion: we need to strategize how to address this because it involves persistence behaviors as well as view/display behaviors as well as the form input behaviors. This may also involve ChangeSet behavior.

bwatson78 commented 4 weeks ago

PR made: https://github.com/emory-libraries/dlp-selfdeposit/pull/593

eporter23 commented 3 weeks ago

To test, go through the originally documented Edit steps and save a change. The UI doesn't change.

eporter23 commented 2 weeks ago

I repeated the steps to trigger this issue as noted in #569 but it is still recurring. Screenshot 2024-11-06 at 1.09.24 PM.png

bwatson78 commented 2 weeks ago

PR made: https://github.com/emory-libraries/dlp-selfdeposit/pull/620

eporter23 commented 1 week ago

This appears to be resolved. Thanks!