emory-libraries / web-enhance

3 stars 0 forks source link

Modify exhibits page to include location #8

Closed lovinscari closed 1 week ago

lovinscari commented 2 years ago

the on-site exhibits page doesn’t include the location of the exhibit. Work with members of the CCR team to revise

maxdmayhew commented 1 year ago

@lovinscari Could you give me a contact from the CCR team to follow up with for this ticket?

CB987 commented 1 year ago

moved locations up out of disabled in /admin/structure/types/manage/exhibition/display/card and added location field in /admin/cohesion/templates/content_templates/node/node_exhibition_card/edit i also added it as a field in the view but that didn’t do anything by itself, so idk if necessary

CB987 commented 1 year ago

image.png using the entity reference location so far-- getting input from Colin Bragg on more specifics.

CB987 commented 1 year ago

image.png image.png experimenting with different ways of and level of detail in displaying the location. this is doing building-level-room. the first image is using location-- but rose's official location is so big that it causes the one line to run over.

CB987 commented 1 year ago

Requested to add level as well.

CB987 commented 1 year ago

image.png @cwbragg does this work for location and level?

CB987 commented 1 year ago

feedback from Colin Bragg: Two questions based on the design above: can ‘Level 1’ either be moved closer to ‘Robert W. Woodruff Library’, with both separated by a comma, or maybe placed below ‘Robert W. Woodruff Library?’

  1. Could there be a space between the main title and “Exhibition Details?”
  2. Likewise, a space between the location and main title?
CB987 commented 1 year ago

Screenshot 2023-07-27 at 6.20.32 PM.pngScreenshot 2023-07-27 at 6.22.00 PM.png

CB987 commented 1 year ago

Screenshot 2023-07-27 at 6.26.09 PM.pngScreenshot 2023-07-27 at 6.26.25 PM.png

CB987 commented 1 year ago

@cwbragg the second set of screenshots is with 10px added on either side of the title (and perhaps the people titling them should keep in mind they should fit on 2 lines? i deleted the location out of Dr. McDaniels' exhibition so they don't overrun, but the only other way to do it would be changing the size of the card which will have a ripple effect!) and dropped the level down below the building. what do you think?

cwbragg commented 1 year ago

@CB987 Looking good! Let me run these by Christian. I just noticed that weird Rose Library one from an earlier example. I wonder where that would show up?

cwbragg commented 1 year ago

Also, I definitely like the level under the location, and the space between everything.

CB987 commented 1 year ago

Screenshot 2023-07-27 at 7.10.27 PM.pngScreenshot 2023-07-27 at 7.11.05 PM.png

CB987 commented 1 year ago

Screenshot 2023-07-27 at 7.27.49 PM.pngScreenshot 2023-07-27 at 7.28.18 PM.png

CB987 commented 1 year ago

@cwbragg some more options.

cwbragg commented 1 year ago

@CB987 I like that last one.

CB987 commented 9 months ago

PR#875

cwbragg commented 8 months ago

@CB987 Ready for deploy to stage

cwbragg commented 1 week ago

The work has been completed.