Closed benson-basis closed 8 years ago
Benson, did you include this in the unified project? If you did; I would just close this PR. Thanks.
Yes all accounted for
On Jul 29, 2016 3:09 PM, "Jinho D. Choi" notifications@github.com wrote:
Benson, did you include this in the unified project? If you did; I would just close this PR. Thanks.
— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/emorynlp/nlp4j/pull/36#issuecomment-236267873, or mute the thread https://github.com/notifications/unsubscribe-auth/ADM9z54LSEHvnAv8pSoI_GtU-A5_tf_Gks5qak_WgaJpZM4JSHBy .
Put the English models in as an 'optional' dependency. This allows the unit test to run and also allows the construction of appassembler command-line wrappers that use them. I hope this is acceptable.