search

emorynlp / nlp4j

NLP framework for JVM languages.
http://emorynlp.github.io/nlp4j/
Other
149 stars 33 forks source link

Start to address issue #4. #5

Closed benson-basis closed 8 years ago

benson-basis commented 8 years ago

This is not ready to merge -- however, I wanted to give you a chance to object to the changes.

The approach I took has ended up resulting in a fair amount of fan-out of changes to APIs to accept String pathnames instead of InputStreams. I didn't want to get involved in sniffing bytes from files to decide upon decompression, and I preferred to make more things pass pathnames.

In the process, I removed some tendencies to leak open files and some tendencies to swallow exceptions or just print the backtraces.

If you hate any of this, please let me know. I could certainly chuck all these changes above IOUtils and implement format sniffing instead. To my taste, this is making the code better, but, as always, chacun a son gout.

benson-basis commented 8 years ago

I still want to do some testing to make sure that the commands all behave themselves.

benson-basis commented 8 years ago

Now I think this is good to go if it's OK with you.