search

emosheeep / vite-plugin-virtual-mpa

Out-of-box MPA plugin for Vite, generate multiple entries using only one template.
https://stackblitz.com/~/github.com/emosheeep/vite-plugin-virtual-mpa
MIT License
120 stars 15 forks source link

Vue project is not including asset URLs in build output html files #68

Closed shivamrawal19 closed 7 months ago

shivamrawal19 commented 8 months ago

I have created a detailed StackOverflow question for this, it is here: https://stackoverflow.com/questions/78192074/combination-of-latest-versions-of-vite-vue-vitejs-plugin-vue-and-vite-plugin

( PS I am not sure if it is related to this library or some other dependency, do guide me if that's the case )

Thank you

emosheeep commented 8 months ago

Could you please provide a minimal reproduction?

emosheeep commented 8 months ago

Well, I missed your repo, I'll take a look when I'm free.

gillesgros commented 7 months ago

Any news ? I ran onto the same problem.

I dug into understanding the problem. It s link to vite 5.1. It runs ok with "vite": "5.0.12", but is broken with "vite": "5.1.6",

Hope it helps

shivamrawal19 commented 7 months ago

oh, based on your hint, I updated the vite from "5.0.10" to "5.0.13". ( max it works is till 5.0.13 not after that ) But It removed the "1 high severity vulnerability" warning, while generating proper builds.

So the issue remains for the latest versions of packages, but at least for now, npm audit is happy with the versions. Thank you @gillesgros

( sry for the close - reopen thing, I had mistakenly closed it )

emosheeep commented 7 months ago

It seems this problem is caused by vite...I'm sure our plugin don't do things about assets.

shivamrawal19 commented 7 months ago

ok, I have posted an issue on Vite's GitHub page.

emosheeep commented 7 months ago

Nice work! Now I'll close this issue, you can re-open it at anytime.