search

emostar / flutter-libphonenumber

libphonenumber plugin for Flutter
MIT License
47 stars 50 forks source link

Add support for retrieving carrier names #13

Closed edwinnyawoli closed 4 years ago

emostar commented 4 years ago

This is a great start, but it should have the matching iOS implementation. Would you be able to add that in @edwinnyawoli ?

edwinnyawoli commented 4 years ago

Implementing it in iOS is going to prove difficult because with Android there was this package that made it very simple and straightforward. I haven't seen anything like that in the libPhoneNumber-iOS port or even in the cpp variant of the libphonenumber project.

emostar commented 4 years ago

With that information, I agree. Can you just add a no-op, returning an empty string for iOS so the "getNameForNumber" method doesn't cause an exception to be raised?

edwinnyawoli commented 4 years ago

Updated pull request with no op ios implementation

emostar commented 4 years ago

@edwinnyawoli Sorry for dropping this, but I just came back and saw you added the no-op in. Thanks a lot for taking care of it!

I'll test this out and confirm everything is working, and then push a new version.

My biggest concern is having to keep this up to date, as the carrier library gets updated at least once a month with changes.