emotion-js / emotion

👩‍🎤 CSS-in-JS library designed for high performance style composition
https://emotion.sh/
MIT License
17.42k stars 1.11k forks source link

Request: Move facepaint into emotion monorepo #2630

Closed Sonic12040 closed 2 years ago

Sonic12040 commented 2 years ago

The problem

Facepaint is documented (and I assume designed) for use with Emotion, but it is still currently in its own repository. Creates (admittedly small) cognitive load when looking for facepaint within emotion codebase.

Proposed solution

Add facepaint to packages in emotionjs/emotion

Alternative solutions

Build facepaint into an emotion package. Do nothing.

Additional context

Current facepaint location: https://github.com/emotion-js/facepaint

If preferred, I can duplicate this issue in emotionjs/facepaint instead.

srmagura commented 2 years ago

IMO it is fine that facepaint is in its own repository as it is not part of Emotion, but rather a completely optional helper library. I don't think any action is required here since the relevant documentation page already links to the facepaint repo.