emotion-js / emotion

👩‍🎤 CSS-in-JS library designed for high performance style composition
https://emotion.sh/
MIT License
17.5k stars 1.11k forks source link

Add scale property as unitless #3240

Closed justinfernald closed 2 months ago

justinfernald commented 3 months ago

What:

Added scale as a unitless property.

Why:

Since scale is a fairly new well adopted property and does not take px value but instead will take unitless values or percentages and it strange to put: scale: "2" MDN: https://developer.mozilla.org/en-US/docs/Web/CSS/scale W3: https://www.w3.org/TR/css-transforms-2/#propdef-scale

How:

These changes were implemented by modifying the unitless package

Checklist:

changeset-bot[bot] commented 3 months ago

🦋 Changeset detected

Latest commit: 3ad87d186c82d03426d7a063cf93205147105d87

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages | Name | Type | | ------------------ | ----- | | @emotion/unitless | Minor | | @emotion/serialize | Patch |

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

codesandbox-ci[bot] commented 3 months ago

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

justinfernald commented 2 months ago

Note that React also has this implemented for their style prop: https://github.com/facebook/react/pull/25601