emotional-cities / pluma-experiments

Data acquisition and benchmark workflows for the wearable data collection unit
MIT License
1 stars 0 forks source link

Refactor VR Harp addresses #99

Closed aspaNeuro closed 3 weeks ago

aspaNeuro commented 1 month ago

This PR change the address space for VR sensors:

Fix #95

glopesdev commented 1 month ago

@aspaNeuro one last comment regarding the protocol addresses:

VR Experiment protocol [225-228] to [185-188]

These seem to have been renamed but are not included in the main README file. This could potentially make sense since they are protocol specific addresses, but should we then include them in an experiment-specific README somewhere in the repo?

aspaNeuro commented 1 month ago

@aspaNeuro one last comment regarding the protocol addresses:

VR Experiment protocol [225-228] to [185-188]

These seem to have been renamed but are not included in the main README file. This could potentially make sense since they are protocol specific addresses, but should we then include them in an experiment-specific README somewhere in the repo?

They are in the main README I think.

Are you saying to copy these as well to the https://github.com/emotional-cities/pluma-experiments/blob/main/VR-Alfama/README.md, I dont think this is relevant information for you to setup the VR.

The experimental protocol itself has some LSL messages that need documentation, I'm currently waiting for feedback from João Amaro on this and created an issue #96 for dealing with these.

aspaNeuro commented 3 weeks ago

@aspaNeuro one last comment regarding the protocol addresses:

VR Experiment protocol [225-228] to [185-188]

These seem to have been renamed but are not included in the main README file. This could potentially make sense since they are protocol specific addresses, but should we then include them in an experiment-specific README somewhere in the repo?

They are in the main README I think.

Are you saying to copy these as well to the https://github.com/emotional-cities/pluma-experiments/blob/main/VR-Alfama/README.md, I dont think this is relevant information for you to setup the VR.

The experimental protocol itself has some LSL messages that need documentation, I'm currently waiting for feedback from João Amaro on this and created an issue #96 for dealing with these.

The commit cd9bfc8417976f31b312394495b1d11d81f2e09c fix this problem