search

emotz / kladovka

Optimizer of inventory for games
http://kladovka.herokuapp.com/
MIT License
0 stars 0 forks source link

Sort #77

Closed ITarako closed 7 years ago

ITarako commented 7 years ago

i will write e2e-tests tomorrow, because i don't want die, while i will try install webdriver on notebook

Eoksni commented 7 years ago

I guess its ready now? For future, please never-EVER push without at least some manual testing. The very basic "happy path" must be successful.

ITarako commented 7 years ago

Before push, all is work. But..I decided rename prop of vue component . It's EZ, only EZ rename, no change in functionality or something else, so after rename I push it and in result I have very stypid error

Eoksni commented 7 years ago

No worries, happens to everyone - renaming in js is hard due to its dynamic nature. Just be more careful next time, and don't forget about "Find and replace in project" Ctrl-Shift-H feature :) I'll review it tomorrow morning, don't have time atm.