emp74ark / pma

2 stars 1 forks source link

App crash on opening board #38

Closed emp74ark closed 1 year ago

emp74ark commented 1 year ago
Uncaught TypeError: Cannot read properties of undefined (reading 'login')
    at defineName (Task.tsx:25:1)
    at Task.tsx:45:1
    at Array.map (<anonymous>)
    at TasksList (Task.tsx:30:1)
    at renderWithHooks (react-dom.development.js:16305:1)
    at mountIndeterminateComponent (react-dom.development.js:20074:1)
    at beginWork (react-dom.development.js:21587:1)
    at HTMLUnknownElement.callCallback (react-dom.development.js:4164:1)
    at Object.invokeGuardedCallbackDev (react-dom.development.js:4213:1)
    at invokeGuardedCallback (react-dom.development.js:4277:1)
emp74ark commented 1 year ago

It was my mistake: when user was removed, its name can't be defined. Quick fix:

function defineName(userId: string) {
    const user = users.all.filter((user) => user.id === userId);
    if (user.length !== 0) {
      return user[0].login;
    }
    return 'unknown'; // TODO: replace by variable with translation
  }