search

empa-scientific-it / cleedpy

MIT License
1 stars 0 forks source link

Switch to CMake #33

Closed edoardob90 closed 10 months ago

edoardob90 commented 10 months ago

fixes #13

Something to add to the README (maybe): set CMAKE_PREFIX_PATH if OpenBLAS library is installed in a non-standard path. For instance, when using Brew on macOS to install the library:

cmake -S . -B build -DCMAKE_PREFIX_PATH="/opt/homebrew/opt/openblas"
codecov[bot] commented 10 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (b632480) 100.00% compared to head (aaf4c29) 100.00%. Report is 1 commits behind head on main.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #33 +/- ## ========================================= Coverage 100.00% 100.00% ========================================= Files 5 5 Lines 22 22 ========================================= Hits 22 22 ``` | [Flag](https://app.codecov.io/gh/empa-scientific-it/cleedpy/pull/33/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=empa-scientific-it) | Coverage Δ | | |---|---|---| | [python-3.10](https://app.codecov.io/gh/empa-scientific-it/cleedpy/pull/33/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=empa-scientific-it) | `100.00% <ø> (ø)` | | | [python-3.11](https://app.codecov.io/gh/empa-scientific-it/cleedpy/pull/33/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=empa-scientific-it) | `100.00% <ø> (ø)` | | | [python-3.12](https://app.codecov.io/gh/empa-scientific-it/cleedpy/pull/33/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=empa-scientific-it) | `100.00% <ø> (ø)` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=empa-scientific-it#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

edoardob90 commented 10 months ago

Reminder: we should also remove the Makefile(s).

yakutovicha commented 10 months ago

Something to add to the README (maybe): set CMAKE_PREFIX_PATH if OpenBLAS library is installed in a non-standard path. For instance, when using Brew on macOS to install the library:

cmake -S . -B build -DCMAKE_PREFIX_PATH="/opt/homebrew/opt/openblas"

I put it to the wiki: https://github.com/empa-scientific-it/cleedpy/wiki/For-Developers