search

empa-scientific-it / python-tutorial

Material for a Jupyter-based Python tutorial
MIT License
30 stars 9 forks source link

Added type hints. #219

Closed baffelli closed 4 months ago

baffelli commented 4 months ago

Closes #102

despadam commented 4 months ago

Shall we also add type hints to the reference solutions?

yakutovicha commented 4 months ago

Shall we also add type hints to the reference solutions?

good catch, @despadam. I was about to approve it. @baffelli could you do that?

baffelli commented 4 months ago

Shall we also add type hints to the reference solutions?

good catch, @despadam. I was about to approve it. @baffelli could you do that?

Done in 5551d78

baffelli commented 4 months ago

Quickly tested, seems to work fine.

I will go through a more careful check before the tutorial, in case of issues, I will update the material accordingly.

Can I merge then?

yakutovicha commented 4 months ago

Quickly tested, seems to work fine. I will go through a more careful check before the tutorial, in case of issues, I will update the material accordingly.

Can I merge then?

There was a problem wit the pre-commit check. I just fixed it.

yakutovicha commented 4 months ago

@baffelli now you can.