empa-tsl / Plastic_PMFA-Emission

Creative Commons Zero v1.0 Universal
1 stars 0 forks source link

Documentation - Readme - Sample data #1

Open sercharpak opened 2 years ago

sercharpak commented 2 years ago

Hello! Thanks for sharing the code! It's amazing! I was trying to go through the repository. Can you provide a little more guidance on how to execute in general? Can you upload some sample data, simple instructions on how to execute and what kind of results to expect? Also, there are a lot of paths hardcoded (if I execute from my machine it will fail). Thanks a lot!

marpellan commented 2 years ago

Hello, thanks a lot for sharing. It supports a lot the journal article.

It would be super nice indeed to have a sample data (maybe dummy data if the original is protected). As well, it would be nice to well document at least the main functions. The different folders should also might be better organised and/or some can be added. Some suggestions : input_data, data_analysis, graphs...

meretamrein commented 2 years ago

Thanks a lot for sharing your paper and code. I think it is a very good approach for monitoring the fate of microplastics in the environment, which is a topic that is hard but important to tackle.

I am trying to reproduce your data in the frame of the Open Science Summer School. However, I was not able to run your script. Some further information about the dataset you used exactly would be necessary. I think I could find the webpage, where the database was taken from, but I would have needed the information about the exact database that was used. Furthermore, some general information about which version of R o which packages have been used. However, I am very new to programming with R, so this might not be an issue for more experienced users.

sian-wusidi commented 2 years ago

Thanks a lot for sharing your code to support your journal article! I'm wondering if you could provide a requirement file to specify the package dependency?

Also, I find there is no header of each script that explains briefly what this script is for. It will also be nice if you could add a flow chart illustrating the execution sequence of those scripts.