emperorshammer / issues-incoming-queue

This is the incoming issues queue for Internet Office-supported projects (sites and applications). Use this repository to request feature enhancements or report bugs.
5 stars 0 forks source link

Printable Characters in Member Names #214

Closed MrPliffles closed 4 months ago

MrPliffles commented 8 months ago
2024-03-14 19_48_07-Post News Article - TIE Corps

If non-printable characters can't be used in news post titles, should we allow them in names? Can work around it by not using the member's name in the title of a news post, but it might make things easier in the long run if we prevented them from putting a non-printable character in their name to begin with (the join form).

turtlexiv commented 6 months ago

Currently assessing this. As a primarily English language organization, having member names that use characters most people can't readily type seems like a pain. This is admittedly somewhat anti-internationalization but there are practical considerations when we're referring to member names.

The code accepts unicode, so currently you could use emojis or other dumb shit in your name that we obviously wouldn't continue to allow.

image

Additional feedback is welcome.

MrPliffles commented 6 months ago

My only real concern is having a member's name that we can't include in a headline without changing its format (and thus it not being the same name, really). If the headline field rejects all accented characters like the ones our international members might use, maybe there are two changes to make?

turtlexiv commented 4 months ago

After checking, I can't actually substantiate that there is a problem with putting his name into a news post.

image

The question about 'weird' unicode characters in a name is still an open and separate question.

turtlexiv commented 4 months ago

Actually, this is a problem on production. I'll have to dig into why.