search

empira / PDFsharp-1.5

A .NET library for processing PDF
MIT License
1.28k stars 588 forks source link

Fix concurrent generation of PDF documents #91

Closed 0xced closed 1 year ago

0xced commented 5 years ago

See IndexOutOfRangeException when generating a PDF thread on the PDFsharp forum.

Note that I implemented the "absolute minimum changes required" solution suggested by @bradleypeet, not the full IFontDataReader solution.

bradleypeet commented 5 years ago

Glad someone noticed and found the fix helpful. I wasn't on Github at the time I was dealing with the thread safety issue or I might have made a pull request.

drvic10k commented 4 years ago

is there any plan to merge this?

ThomasHoevel commented 4 years ago

Stefan is aware that there are a few PRs here, but he didn't tell me yet how to proceed with them.

0xced commented 4 years ago

Click the merge button and publish a new release? 😉

ThomasHoevel commented 4 years ago

Click the merge button and publish a new release? 😉

Is it that simple? There are 31 PRs and in some cases we do not have sample PDFs that allow to replicate the issue. I don't think that clicking "Merge" 31 times and hoping for the best is a good approach here.

This is not the master repository anyway.

fatceken commented 3 years ago

I have the same issue. Is there any plan to merge to master ?

drvic10k commented 3 years ago

is this project abandoned?

ThomasHoevel commented 3 years ago

is this project abandoned?

No.

drvic10k commented 3 years ago

is this project abandoned?

No.

so is there a plan to include the fixes from pull requests any time soon?

otherwise I would need to build a separate version with the fix

ThomasHoevel commented 3 years ago

so is there a plan to include the fixes from pull requests any time soon?

I don't think it will happen "soon". Just my gut feeling, no official statement.

ThomasHoevel commented 1 year ago

Fixed in current internal builds. Thanks for the feedback.