empira / PDFsharp

PDFsharp and MigraDoc Foundation for .NET 6 and .NET Framework
https://docs.pdfsharp.net/
Other
398 stars 91 forks source link

How to build PDF Sharp with Strong name? #104

Closed SeanBerrir closed 2 months ago

SeanBerrir commented 2 months ago

Hi Team,

Need to install PDFSharp to Global Assembly Cache. However, it doesn't have a strong name. Building it with a strong name for each of the projects is throwing errors. Though build succeeded when building the entire solution as is. But won't install in GAC.

Any thoughts?

StLange commented 2 months ago

Very good point! During development of PDFsharp 6.0 we removed all strong names because there is no GAC anymore. When we retrofit PDFsharp 6.1 for .NET Framework / Standard 2.0 we forgot that. With the very soon coming Preview 3 of PDFsharp 6.1 all assemblies in the NuGet packages are again signed with a strong name. Thank you for reminding us.

SeanBerrir commented 2 months ago

Thank you. Glad to help.

StLange commented 2 months ago

Done in 6.1.0 Preview 3