empira / PDFsharp

PDFsharp and MigraDoc Foundation for .NET 6 and .NET Framework
https://docs.pdfsharp.net/
Other
467 stars 109 forks source link

Link to fix to Accessibility StructureBuilder.cs does not exist, might be related to our issue. #144

Open CameronMichael opened 1 month ago

CameronMichael commented 1 month ago

We are dealing with an issue that we are trying to resolve that we posted on the forum Accessibility merge issue, that perhaps we should post here where accessibility tags are not kept when the merge occurs. I found a note that in 6.0 there is an accessibility bug regarding enums. but the link to this fixed file does not exist. here: https://docs.pdfsharp.net/PDFsharp/Topics/PDF-Features/Accessibility.html#bug

Expected Behavior

When you click the link you should see the file fixed, or this removed saying it was updated/fixed in 6.1.

Actual Behavior

https://docs.pdfsharp.net/PDFsharp/Topics/PDF-Features/Accessibility.html#bug Click on structuredBuilder.cs and you get a file not found error

Steps to Reproduce the Behavior

go to https://docs.pdfsharp.net/PDFsharp/Topics/PDF-Features/Accessibility.html#bug
click on structuredBuilder.cs

StLange commented 1 month ago

With PDFsharp you can only create PDF/UA files when you create a new PDF document. Merging existing PDF/UA files does not work. Merging cannot preserve the documents structure tree. It is not implemented and not easy to do. I will discuss the problem with the developer who wrote the code.

The link to the fix is a different issue. There was a bug with some enums which is already fixed in 6.1.1. This does not help with your merging problem.

The link was actually not working. This was because docs.pdfsharp.net is created with docfx and published by an Azure pipeline as an Azure Static Web App. And because .cs is`` not a valid mime type for downloading by default, it does not work on Azure. I fixed that on the fly by renaming the file to .cs.txt.

CameronMichael commented 1 month ago

Thank you for the clarification and quick response, we are looking to have a path to merge with tags still in place. The solution we currently have does this, but we can not continue with it and need to have a different path forward. I appreciate any insight and ideas on how it could be done as it would be a great feature to add and keep us using pdfsharp as the primary pdf solution in our stack.