search

empira / PDFsharp

PDFsharp and MigraDoc Foundation for .NET 6 and .NET Framework
https://docs.pdfsharp.net/
Other
531 stars 132 forks source link

Image Selector collision causes the wrong image to be drawn #191

Closed bsouthard-jackhenry closed 1 month ago

bsouthard-jackhenry commented 1 month ago

The attached sample attempts to create a two page document from two different images. However, the first image is displayed on each page. Debugging the issue shows that only one image is stored in the document's image table because the same selector value is calculated for each image. It would seem this would be a rare MD5 hash collision and yet here it happens. Perhaps the selector individuality can be improved beyond simply the hash value.

Issue.zip

TH-Soft commented 1 month ago

Looks like a duplicate of issue 127. Fix will be in 6.2.0 Preview 2.

bsouthard-jackhenry commented 1 month ago

That's great news. Thanks!

bsouthard-jackhenry commented 1 month ago

Thanks again, Thomas!

From: Thomas Hövel @.> Sent: Monday, October 21, 2024 2:11 PM To: empira/PDFsharp @.> Cc: Brent Southard @.>; Author @.> Subject: Re: [empira/PDFsharp] Image Selector collision causes the wrong image to be drawn (Issue #191)

External Email -

Looks like a duplicate of issue 127. Fix will be in 6. 2. 0 Preview 2. — Reply to this email directly, view it on GitHub, or unsubscribe. You are receiving this because you authored the thread. Message ID: empira/PDFsharp/issues/191/2427396851@ github. com ZjQcmQRYFpfptBannerStart This Message Is From an External Sender Do not open attachments or click links from an unknown source. Forward suspicious emails to Anti-Spam.

ZjQcmQRYFpfptBannerEnd

Looks like a duplicate of issue 127. Fix will be in 6.2.0 Preview 2.

— Reply to this email directly, view it on GitHubhttps://urldefense.com/v3/__https://github.com/empira/PDFsharp/issues/191*issuecomment-2427396851__;Iw!!AjeAU-2VoVEOzw!eE6Mx555slbEvgA18vTUOsf4yRYWvOZsnciRLv0acwccCYnhvMW_0AbHkUmy6D2DIqA8yRPR6jWQrP3HO2QbwIPY4dM$, or unsubscribehttps://urldefense.com/v3/__https://github.com/notifications/unsubscribe-auth/APUEWAS4HVNJ5VGGHDVLCITZ4U7VHAVCNFSM6AAAAABQKXEYM6VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDIMRXGM4TMOBVGE__;!!AjeAU-2VoVEOzw!eE6Mx555slbEvgA18vTUOsf4yRYWvOZsnciRLv0acwccCYnhvMW_0AbHkUmy6D2DIqA8yRPR6jWQrP3HO2QbO2v9RYI$. You are receiving this because you authored the thread.Message ID: @.***>

NOTICE: This electronic mail message and any files transmitted with it are intended exclusively for the individual or entity to which it is addressed. The message, together with any attachment, may contain confidential and/or privileged information. Any unauthorized review, use, printing, saving, copying, disclosure or distribution is strictly prohibited. If you have received this message in error, please immediately advise the sender by reply email and delete all copies.