search

empirical-org / Empirical-Core

Empirical Core is the mono repo for the Quill.org codebase. This repo contains both the Quill Learning Tools, such as Quill Connect, and the Quill Learning Management System, the platform that enables teachers to provide assignments and view results. (Empirical is the name of the nonprofit building Quill.org).
http://www.quill.org/
GNU Affero General Public License v3.0
25 stars 4 forks source link

Bug report - activities out of order in the pack. #4757

Closed petergault closed 5 years ago

petergault commented 5 years ago

Please try and explain the issue here. If you need to add any personal information for users, add that info to a google doc and link to it here. Restrict it to quill.org staff.

Expected Behaviour

Certain activity packs, but not all activity packs, are consistently assigning packs in the correct order from the stated order in the featured activity pack.

screen shot 2018-10-31 at 10 58 46 pm

Actual Behaviour

The assignment order for the activity pack: screen shot 2018-10-31 at 10 58 57 pm

Steps to Reproduce

Assign the featured pack. Delete it and re-assign, and the same order appears.

Instances of bug

https://www.quill.org/teachers/classrooms/assign_activities/featured-activity-packs/47

Appositives instance

https://www.quill.org/teachers/classrooms/assign_activities/featured-activity-packs/27

Expected

screen shot 2018-10-31 at 10 57 26 pm

Assignment

screen shot 2018-10-31 at 10 57 52 pm

Using Commas

https://www.quill.org/teachers/classrooms/assign_activities/featured-activity-packs/3

Intended

screen shot 2018-10-31 at 10 56 18 pm

Actual

screen shot 2018-10-31 at 10 56 09 pm

Since & Because Packs

Intended

screen shot 2018-10-31 at 11 14 15 pm

Actual

screen shot 2018-10-31 at 11 16 54 pm

Note: there are a number of packs where the assignments are in the correct order. These are the one that I found that are not in order.

buckmaxwell commented 5 years ago

@petergault , can you tell me which account you were logged into when you saw this?

petergault commented 5 years ago

@buckmaxwell It's a new account that I created last night. Here's a link to the account info: https://docs.google.com/document/d/1hlKOswB4FesC28iKPvvaxdYgytjiQmWKfsESPB6f_2Q/edit

Some additional details:

  1. I looked at about 8 packs, and only these 3 were out of order. Not all packs are out of order, but these 3 are. If this is a bug that is related to specific packs, we'll need to do an audit of all of the packs. Please let @Hannahmonk know if there is something that is specific to those packs that can be fixed by re-ordering.

How many teachers have reported this? Does the number seem to be increasing quickly?

It presumably impacts every teacher who has assigned the pack since the bug was introduced.

If there are multiple reports, are they clustered together (e.g. they all came in this week), or do they appear to be more isolated (e.g. 2 separate reports 3 months apart)?

No bug reports -found it myself through testing the site.

When do you think the bug was introduced? E.g. We saw this today vs we've been seeing for five years.

Not sure

In your opinion, is this sitewide or limited to the teachers who are reporting? If limited, approximately how many people are affected? E.g. "This applies to all teachers using Google classroom, but not teachers using other sign-in tools."

Site wide for everyone assigns these packs.

What is the scope? E.g. Is it limited to people using one question in one activity pack, or does the error occur for all activity packs on Quill?

It is not all activity packs. Of the 8 packs I looked at, it impacted 3.

Is the a workaround, or does the bug completely prevent those affected from using Quill in their desired way? For example, if there is a bug in the preview bar for diagnostics, students can still do the diagnostics. This would still be high priority, but not as high as a bug that prevented students from taking the diagnostics.

This is high priority because the students are receiving their assignments out of order. It's very important that students receive their lessons in the correct order as the lessons build on each other.

Are there related bugs that we have open?

Not Sure

Is this related to an issue that we've had recently? E.g. "Last week we had several complaints about the lessons projector. It's fixed now, but there's another error in lessons preventing teachers from using it, and when they talk to support they are noting that lessons has not been reliable this month."

not sure.

buckmaxwell commented 5 years ago

activities_units_templates is a join table that has no incrementing primary key. we rely on the order or results from this table to create activities in the correct order - miraculously they often come back in the right order, but they don't always because there is no field to order them on. Adding an incrementing pkey to make this table operate as a log should allevieate the issue. I'll make a PR for this tomorrow.