Players Freezing during unManaged Game when new player begins intro steps

Jeffotter commented 1 year ago

Is there an existing issue for this?

[X] I have searched the existing issues

What happened?

When I begin a default app and attempt to make a game with a custom assignment. I created four games,

2 default 3-player games
2 default 5-player games For these games, I am doing the custom game assignment. I will attach my codes below. When I am adding people to the first game. (A five-person usually, although it shouldn't matter) I have the game start after two players have finished their intro checks. While these players are guessing jelly beans. I have a third player start the process In order for they

Input their ID -- no issues. Begin intro steps -- (players currently guessing jellybeans freeze to a loading screen)

When I refresh the two original players, they can now see the avatar of the new player while the new player is still in the intro steps.

Game resumes

Steps To Reproduce

Create a default game
Make a treatment
Modify App.jsx , Stage.jsx, Callbacks.jsx, server/index.js (code locations attached below, error was occurring before stage modification ) Custom assignment copied from here (https://github.com/JamesPHoughton/external-grouping)
Start the game and create 3 Players
Run 2 players through the intro steps and the game will begin
While the game is running, start the third player
After the 3rd player submits his ID the other two players will be frozen.
Refresh on the two original players and see the third player who should still be in the intro steps

Empirica Version

Version: v1.6.0
SHA:     0d26251
Branch:  main
Time:    2023-08-10T11:36:38Z

Client:  1.6.0
Server:  1.6.0

What OS are you seeing the problem on?

macOS

What browser are you seeing the problem on?

Chrome

Relevant log output

There are no errors That I can see either the console logs or the IDE logs

Anything else?

https://github.com/Jeffotter/demo_unmanagedGame/blob/main/server/src/callbacks.js https://github.com/Jeffotter/demo_unmanagedGame/blob/main/server/src/index.js

https://github.com/Jeffotter/demo_unmanagedGame/blob/main/client/src/Stage.jsx https://github.com/Jeffotter/demo_unmanagedGame/blob/main/client/src/App.jsx

Code of Conduct

[X] I agree to follow this project's Code of Conduct

npaton commented 1 year ago

Thank you, @Jeffotter. I can't seem to access your repo. Would you mind adding me as a contributor with Read permission? Thanks!

Jeffotter commented 1 year ago

@npaton done! Sorry about that

npaton commented 1 year ago

It is happening because assignPlayer is called without await. To fix it, you need to add an async around that callback and add await on the assignPlayer line.

It took me a while to find the issue, it did not jump at me, and this is likely to cause problems for others. We'll make sure to have a warning about it in the docs when they are done. I've also created a fix for this, so that we commit all the changes even if await was not used: https://github.com/empiricaly/empirica/pull/410. But I am currently unsure about the consequences of changing this behavior, so I haven't merged it yet. TBD

empiricaly / empirica