empiricaly / meteor-empirica-core

Core Meteor package for the experiment Empirica platform. This is where you should submit issues.
MIT License
27 stars 13 forks source link

fix white space created by header by changing nav bar classes #259

Closed Karakaii closed 3 years ago

Karakaii commented 3 years ago

Description

I took out the blueprint Navbar and NavbarGroup components for divs with their own classes. I have added a class to admin.less. This allows for more control over the styling of these elements. Notably, it allows for using flex boxes instead of aligns, preventing the problem where it caused white screen on smaller screen sizes.

Motivation and Context

It fixes this issue: #252

How Has This Been Tested?

Connected a basic template Empirica app to my modified empirica-core code. Made sure it the styling did what it was supposed to do in Firefox and Chrome. Testing from WSL Ubuntu.

Screenshots (if appropriate):

image

image

Types of changes

Checklist:

I tried my best to check that it was working and that it was helpful. I am happy to hear how this might need to be tweaked further. First time I am doing a change for a big repo like this one.

Karakaii commented 3 years ago

Thank you! I have made those changes.