search

emporia-vue-local / emporia-vue2-reversing

MIT License
54 stars 12 forks source link

Change phase voltages to int16 #3

Closed Maelstrom96 closed 3 years ago

Maelstrom96 commented 3 years ago

See : https://github.com/flaviut/emporia-vue2-reversing/issues/1#issuecomment-977171995

The voltages are the only values that are a 1:1 match when parsed as int16. It would be logical to parse it as such.

Maelstrom96 commented 3 years ago

Please ignore this - parsing as uint16 will result in the same values.

krconv commented 3 years ago

I'm not sure that it's uint16, but the values seemed to only increase when I applied higher voltage, and I never saw the bytes go below 0x0000 to 0xFFFF to indicate a negative number; I'm guessing it'll be easier to determine if they're wrong once we have a calibration formula applied to it too