escape() in xssPrevent and xssDisplay converts umlaute (äöü)

emposha / FCBKcomplete

Jquery facebook like(fancy) multi-select

http://www.emposha.com

383 stars 115 forks source link

escape() in xssPrevent and xssDisplay converts umlaute (äöü) #67

Closed serkantueten closed 13 years ago

serkantueten commented 13 years ago

The escape() command in the function xssPrevent() and xssDisplay() encodes all german umlauts (ä, ö, ü, ... %E4, %F6, %FC) and the etext gets 'wrong' characters.

emposha commented 13 years ago

Strange, do you have any test page with this, because I tried to reproduce this bug with "hellö worldä" key & value, and everything work as expected. Do you use utf8 encoding?

serkantueten commented 13 years ago

strange indeed...

I set up a test:

downloaded from git
added a new node to data.txt (Österreich)
added 2 x console.log to FCBKcomplete on line 188: var etext = xssPrevent(input.val()); console.log( 'var input.val() before xssPrevent call: ' + input.val() ); var etext = xssPrevent(input.val()); console.log( 'var etext after xssPrevent call: ' + etext );
upped to http://www.modulus.ch/FCBKcomplete/

if you search for 'Ö...' nothing appears. try 'sterreich' and you get the record. hope this helps...

emposha commented 13 years ago

Ok, fixed. Waiting for you confirmation.

serkantueten commented 13 years ago

works great for me now!

however there is another issue: the found letters aren't highlighted if you search for 'Österreich'... you can try again on my testpage. I have added another record 'Tüten' for testing.

emposha commented 13 years ago

ok, checking

emposha commented 13 years ago

Fixed, new version pushed.

serkantueten commented 13 years ago

work like a charm. thank you!

serkantueten commented 13 years ago

hmmm... strange behaviour found:

just type 'f' in the searchfield and you will find 'T%FCten' in the list where the 'F' get's highlighted.
searching for 'ö' in small letter won't give any result with 'Ö' in big letters where searching for 'S' gives also words starting in small letters

emposha commented 13 years ago

yep case-sensitive useless in this case, I will try to find workaround...

emposha commented 13 years ago

Pushed new version, can you try?

serkantueten commented 13 years ago

seems to be ok, thx!