As a user I need to be able to use my browser back button to go back even when scrolling to an anchor tag - Githubissues

empowerai / fs-permit-platform

Module for intake of special use applications for Forest Service Application Permits

Other

3 stars 0 forks source link

As a user I need to be able to use my browser back button to go back even when scrolling to an anchor tag #149

Open sadlerw opened 6 years ago

sadlerw commented 6 years ago

Notes

Angular 2 has broken history with anchor tags. A possible solution is at https://stackoverflow.com/questions/36101756/angular2-routing-with-hashtag-to-page-anchor and https://github.com/angular/angular/issues/6595

We should evaluation whether the present behavior is adequate or we need to restore history.

Acceptance criteria

[x] user can press back button after pressing an internal anchor link on a page and go back to the previous anchor

Tasks

[x] implement gotoHashtag() per notes above (seth)
[x] fix the missing page title when using gotoHashtag (seth)

Definition of Done

[x] Code unit / e2e tested and comply with QWASP
[x] No new security vulnerabilities
[x] Internal team code review
[x] Documentation / readme.md / CircleCI updated
[x] Docker updated
[x] Compare finished design with mockup
[x] Usability tested

bryanmcfadden commented 6 years ago

This also came up in the sprint 04 usability testing: https://github.com/nciinc/fs-intake-module/wiki/Sprint-04-Christmas-tree-ePermit-research-results

sadlerw commented 6 years ago

tested on staging - looks good