As a prospective christmas tree applicant, I would like to be redirected back to my information page if application is unable to connect to pay.gov.

shekarpendem commented 6 years ago

Notes

Acceptance Criteria

[x] user is returned to the application form with values populated
[x] user can tell difference between a system error and a problem with their application form
[x] user can tell what their next step is (try again, call district, etc.)

Tasks

[x] update user flow model (bryan)
[x] Server: mock token failure (shekar)
[x] Frontend: pre-fill application form when user returns after unsuccessful connection to pay.gov (cameron)
[x] Frontend: error message on form (cameron)
[x] e2e spec
[x] server specs (shekar)
[x] frontend specs
[x] Break getOnePermit function in christmas-trees.es6 into multiple named functions. (Cameron)
[x] Pull pay.gov xml out of functions and into own file.(Cameron)
[x] Pull svg create function out of paygov.es6 and put into a file called e.g. create-svg.es6, try to break up the method into smaller functions. (Cameron)
[x] Address code feedback from Laura (Seth/Shekar/Cameron)
[x] Design Pre-approved (TTS)
[x] Design approved (Amber)

Definition of Done

[x] Code unit / e2e tested and comply with QWASP
[x] No new security vulnerabilities
[x] Internal team code review
[x] Documentation / readme.md / CircleCI updated
[x] Docker updated
[x] Compare finished design with mockup
[ ] Usability tested

sethalt commented 6 years ago

@tram We have a couple of error messages for you to review. the first is the global error message when there is a 500 error. Per conversations with @bryanmcfadden, we changed the text from 'Server error' to 'We were unable to process your request.'

The next error is when we get an error response from pay.gov. We are on the fence about including the pay.gov error message, but we decided to put it in there in case a user needed to relay the message to customer service. What are your thoughts there?

tram commented 6 years ago

👍 Humanizing "Server error". 🤔 In what instances are people most likely to see these errors? I'm wondering how long "please try again later" is recommending to wait—try again now or in an hour or tomorrow. If they should try again now, maybe something like…

<div class="usa-alert usa-alert-error" role="alert">
<div class="usa-alert-body">
<h3 class="usa-alert-heading">Sorry, we were unable to process your request. Please try again.</h3>
<p class="usa-alert-text">If you continue to get this error, please contact<a href="mailto:fs-permitting-project@gsa.gov">fs-permitting-project@gsa.gov</a>.</p>
</div>
</div>

sethalt commented 6 years ago

good recommendation @tram. This should 'never' happen, however, sometimes servers do go down. In this case, the error would be if there is a misconfiguration on pay.gov or if pay.gov's server is down. In most cases, please try again should fix the issue.

sethalt commented 6 years ago

Updated per your feedback @tram