As a system admin, I would like to have circleCi leverage the checked in `vcap-services/local-or-ci.json` to be used at the base for the VCAP_SERVICE env var.

[lauraGgit]

Notes

add to the circle config something to copy over the checked in vcaps structure - to minimize the amount that needs to be stored in circles env vars -

export VCAP_SERVICES=$(cat vcap-services/local-or-ci.json) and then overwrite the subobject of VCAP_SERVICES.s3 with jq by pulling in the relevant credentials from the circle environment variables.

Acceptance Criteria

• [x] changes to vcap services shouldn't cause circle to break

Tasks

• [x] pull vcap services from yaml into docker (cameron/seth)
• [x] get circle to use vcap in docker or from code (drop vcap entirely in circle?) (cameron/seth)
• [x] clear s3 bucket after tests run. (Seth/Cameron/Shekar)
• [x] adding s3 instructions to readme. (Seth/Cameron/Shekar)
• [x] Where are aws credentials are being pulled in, need to update the temp outfitter controller so that aws credentials are pulled in from local env if not in vcap. (Seth/Cameron/Shekar)
• [x] look into pulling database_url into circle config (example: https://github.com/18F/crime-data-api/blob/master/circle.yml) (Cameron)
• [x] make sure typedocs are accessible (currently 404 intercepter breaks route) (Will)
• [x] Fix e2e tests (seth)

Definition of Done

• [x] Code unit / e2e tested and comply with QWASP
• [x] No new security vulnerabilities
• [x] Internal team code review
• [x] Documentation / readme.md / CircleCI updated
• [x] Docker updated
• [x] Compare finished design with mockup
• [ ] Usability tested

[ASprinkle]

I have no idea what this means, but it sounds important!